Migrate docs and container setup to full Next.js workflow#2
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
next dev/next start) rather than statically serving a Webpack build.Description
README.mdto describe a Next.js-based stack, update local/dev/prod commands, and remove Webpack-specific wording and preview steps.Dockerfileto a Node-based Next.js runtime that runsnpm run startand copies the.nextbuild output and pages into the image.docker-compose.ymlanddocker-compose.override.ymlto use port4173consistently and run the Next.js dev server on that port with the appropriate dev command arguments.Makefileto replace the obsoletepreviewtarget with astarttarget and keep other convenience targets in sync with Next.js commands.Testing
npm run typecheckwhich completed successfully (tsc --noEmit).rg -n "webpack" --glob '!package-lock.json'which showed no remaining references to Webpack outside ofpackage-lock.json.docker compose configbut the Docker CLI is not available in this environment so container config could not be validated.npm run buildin this environment but the Next.js runtime binary could not be resolved here, so a full build validation was not completed.Codex Task