More gracefully handle errors on leaving consumer group #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be related to #247 though it may not be the root cause. We were seeing the leave group fail with an `unknown_member_id`, which happens when there is a problem between the client and the broker. This would cause the manager to exit abruptly and may be causing the rest of the consumer group's processes to exit uncleanly. Regardless of the error returned, we want to exit the consumer group cleanly.
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/kafkaex/kafka_ex/pulls/248. |
bjhaid
reviewed
Nov 16, 2017
Member
bjhaid
left a comment
bjhaid
left a comment
There was a problem hiding this comment.
This is the piece of the code I least understand, looks good to me, I think you should seek an extra eye beyond mine. However if you feel confident about it you can go ahead to merge
joshuawscott
approved these changes
Nov 17, 2017
robotarmy
pushed a commit
to RAM9/kafka_ex
that referenced
this pull request
Apr 7, 2025
More gracefully handle errors on leaving consumer group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be related to #247 though it may not be the root cause.
We were seeing the leave group fail with an
unknown_member_id, whichhappens when there is a problem between the client and the broker. This
would cause the manager to exit abruptly and may be causing the rest of
the consumer group's processes to exit uncleanly.
Regardless of the error returned, we want to exit the consumer group
cleanly.