Skip to content

More gracefully handle errors on leaving consumer group #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2017
Merged

More gracefully handle errors on leaving consumer group #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d08a4c
More gracefully handle errors on leaving consumer group
dantswain Nov 16, 2017
966175a
Fix string concatenation
dantswain Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/kafka_ex/consumer_group/manager.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,17 @@ defmodule KafkaEx.ConsumerGroup.Manager do
member_id: member_id,
}

%LeaveGroupResponse{error_code: :no_error} =
leave_group_response =
KafkaEx.leave_group(leave_request, worker_name: worker_name)

Logger.debug(fn -> "Left consumer group #{group_name}" end)
if leave_group_response.error_code == :no_error do
Logger.debug(fn -> "Left consumer group #{group_name}" end)
else
Logger.warn(fn ->
"Received error #{inspect leave_group_response.error_code}, " <>
"consumer group manager will exit regardless."
end)
end

:ok
end
Expand Down