fix(controller): wire up SessionSharesHandler in NewHandlers - #2363
Merged
Conversation
`SessionShares` was declared on the `Handlers` struct and routed in server.go, but never constructed in `NewHandlers`, leaving it nil and resulting in a nil pointer dereference when any caller tried to make use of the endpoint. Seems to have somehow got lost in the final commits on kagent-dev#1935. Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox
force-pushed
the
fix-session-share
branch
from
July 30, 2026 08:09
0580939 to
7181e9c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an initialization gap in the Go HTTP server handler wiring: the SessionShares handler was routed but never constructed in NewHandlers, which could lead to a nil pointer dereference when the session sharing endpoints are called.
Changes:
- Construct
SessionSharesHandlerinNewHandlersby wiringSessionShares: NewSessionSharesHandler(base). - Ensures the already-registered session share routes in
server.gohave a non-nil handler implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peterj
approved these changes
Jul 30, 2026
EItanya
approved these changes
Jul 31, 2026
onematchfox
added a commit
to onematchfox/kagent
that referenced
this pull request
Aug 11, 2026
…dev#2363) `SessionShares` was declared on the `Handlers` struct and routed in server.go, but never constructed in `NewHandlers`, leaving it nil and resulting in a nil pointer dereference when any caller tried to make use of the endpoint. Seems to have somehow got lost in the final commits on kagent-dev#1935. Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionShareswas declared on theHandlersstruct and routed in server.go, but never constructed inNewHandlers, leaving it nil and resulting in a nil pointer dereference when any caller tried to make use of the endpoint.Seems to have somehow got lost in the final commits on #1935.