ci: scope push trigger to main to avoid duplicate PR runs#33
Merged
Conversation
The push trigger matched every branch (`branches: ['**']`), so opening a PR from a feature branch fired CI twice: once on the branch push and once on the pull_request event, both against the same commit. Restrict push to `branches: [main]` (post-merge builds) while keeping `tags: ['*']` intact so release tag builds still publish. Feature-branch validation is fully covered by the existing pull_request trigger, so each PR now runs CI exactly once.
🔍 Kai reviewKai analyzed this pull request and posted a verification review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a PR from a feature branch currently fires CI twice against the same commit — once on the branch
pushand once on thepull_requestevent (see PR #32, runs #134 and #135).Fix
Scope the
pushtrigger tomainonly:pull_requesttrigger, so each PR now runs CI exactly once.mainstill builds post-merge.tags: ['*']is left intact, so version-tag release builds (GCS + GitHub Releases dual-publish) are unaffected.