docs: sync FLAGS.md with actual CLI arguments - #455
Closed
SpiliosDimakopoulos wants to merge 1 commit into
Closed
Conversation
Removed -p/--permute, which no longer exists anywhere in __main__.py (patterns are now used inline with -u/-e, e.g. -u 'john[a-c]'). Added -U/--update and --version, which exist in the CLI but were missing from this table.
Collaborator
Even though you stated this, this change wasn't implemented in this PR. |
Owner
Owner
|
This PR will be covered in #459 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/FLAGS.md was out of sync with the actual argparse definitions in
main.py:
-p, --permute: this flag doesn't exist anywhere in thecodebase (verified via repo-wide grep). Pattern-based permutations are
generated inline via -u/-e (e.g.
-u "john[a-c]"), as already showncorrectly elsewhere in this same file and in the README.
-U, --updateand--version: both exist in main.py'sargparse but were missing from this table.
Docs only, no code changes.