fix: YouTube username module false positives - #475
Merged
kaifcodec merged 1 commit intoJul 28, 2026
Merged
Conversation
kaifcodec
added
enhancement
kaifcodec
approved these changes
Jul 28, 2026
kaifcodec
left a comment
kaifcodec
left a comment
Owner
There was a problem hiding this comment.
@kristoisberg It's perfect and the issue is fixed, by the way really impressive, how detailed you check the issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the YouTube username module reporting false positives with all usernames. The module currently reports the username as taken whenever the visited page does not explicitly say that the user does not exist. However, at least in my case, the request does not even reach the actual target as it is redirected to a YouTube consent page, and the module considers this valid.
?cbrd=1&ucbcb=1query parameters, which skip the YouTube consent page and go directly to the user profile or 404 pageI think I have patched all false positives I've discovered now.