feat: add Polarsteps username module - #482
Merged
kaifcodec merged 2 commits intoJul 30, 2026
Merged
Conversation
A-S-Manoj
reviewed
Jul 29, 2026
A-S-Manoj
left a comment
A-S-Manoj
left a comment
Contributor
There was a problem hiding this comment.
Nice work on this one — logic looks solid and follows the existing validator pattern well. Left a couple of non-blocking suggestions inline (mostly around long-term robustness of the hardcoded API version), but nothing that should hold up the merge. LGTM overall
Co-authored-by: A Sivasubramanian Manoj <sivasubramanianmanoj2310533@ssn.edu.in>
Collaborator
Author
|
@A-S-Manoj Thanks for the review and suggestions, failing loudly is a great idea. |
kaifcodec
approved these changes
Jul 30, 2026
kaifcodec
left a comment
kaifcodec
left a comment
Owner
There was a problem hiding this comment.
@kristoisberg This is perfect now and working.
Thank you @A-S-Manoj for the review on this.
MERGING IT!
kaifcodec
added
the
user module addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Username module for the travel tracking app polarsteps.com. The enhancements are very detailed here since we could access them directly from their API with little effort.