Skip to content

Removed Travis automation, added GH Actions build & publish to npm #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2020
Merged

Removed Travis automation, added GH Actions build & publish to npm #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0086f1
Removed Travis automation, added GH Actions build & publish to npm
GreyCat May 4, 2020
5921f1b
Added package-lock.json; reformatted package.json
GreyCat May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: npm build

on:
push:
branches:
- master
pull_request: {}

jobs:
publish-npm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
registry-url: https://registry.npmjs.org/
- run: npm ci
- name: Publish to npm
run: npm publish --tag next
env:
NODE_AUTH_TOKEN: ${{secrets.npm_token}}
Copy link
Member

@generalmimon generalmimon May 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to double check if that method of supplying the auth token is correct.

@GreyCat Yeah, it obviously can't work, because your secret is called NODE_AUTH_TOKEN, not npm_token. So it should be probably ${{ secrets.NODE_AUTH_TOKEN }}.

Copy link
Member Author

@GreyCat GreyCat May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks! Fixed, let's try it again.

if: github.ref == 'refs/heads/master'
13 changes: 0 additions & 13 deletions .travis.yml
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 15 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,26 @@
{
"name": "kaitai-struct",
"version": "0.9.0-SNAPSHOT.1",
"version": "0.9.0-SNAPSHOT.3",
"description": "Kaitai Struct: runtime library for Javascript",
"main": "index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/kaitai-io/kaitai_struct_javascript_runtime.git"
},
"keywords": ["kaitai", "binary", "parsing", "struct", "stream", "runtime", "file", "format", "structure", "forenics", "reversing", "reverse engineering"],
"keywords": [
"kaitai",
"binary",
"parsing",
"struct",
"stream",
"runtime",
"file",
"format",
"structure",
"forenics",
"reversing",
"reverse engineering"
],
"author": "Kaitai team (https://github.com/orgs/kaitai-io/people) and Ilmari Heikkinen",
"license": "Apache-2.0",
"bugs": {
Expand Down