Feat/app shell - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an initial application shell and page structure for the Angular app, wiring basic routes and adding a linting setup to support ongoing development.
Changes:
- Added standalone page components (Home, Legal Notice, Privacy Policy, Project Detail, Not Found) and routed them via
app.routes.ts. - Introduced layout components (
Header,Footer) and embedded them into the root app template around the router outlet. - Added ESLint + angular-eslint configuration and an Angular CLI lint target (
ng lint).
Reviewed changes
Copilot reviewed 27 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/app/pages/project-detail/project-detail.ts | Adds placeholder Project Detail page component. |
| src/app/pages/project-detail/project-detail.spec.ts | Adds basic creation test for Project Detail. |
| src/app/pages/project-detail/project-detail.html | Adds placeholder template for Project Detail. |
| src/app/pages/project-detail/project-detail.css | Adds stylesheet placeholder for Project Detail. |
| src/app/pages/privacy-policy/privacy-policy.ts | Adds placeholder Privacy Policy page component. |
| src/app/pages/privacy-policy/privacy-policy.spec.ts | Adds basic creation test for Privacy Policy. |
| src/app/pages/privacy-policy/privacy-policy.html | Adds placeholder template for Privacy Policy. |
| src/app/pages/privacy-policy/privacy-policy.css | Adds stylesheet placeholder for Privacy Policy. |
| src/app/pages/not-found/not-found.ts | Adds placeholder Not Found page component. |
| src/app/pages/not-found/not-found.spec.ts | Adds basic creation test for Not Found. |
| src/app/pages/not-found/not-found.html | Adds placeholder template for Not Found. |
| src/app/pages/not-found/not-found.css | Adds stylesheet placeholder for Not Found. |
| src/app/pages/legal-notice/legal-notice.ts | Adds placeholder Legal Notice page component. |
| src/app/pages/legal-notice/legal-notice.spec.ts | Adds basic creation test for Legal Notice. |
| src/app/pages/legal-notice/legal-notice.html | Adds placeholder template for Legal Notice. |
| src/app/pages/legal-notice/legal-notice.css | Adds stylesheet placeholder for Legal Notice. |
| src/app/pages/home/home.ts | Adds placeholder Home page component. |
| src/app/pages/home/home.spec.ts | Adds basic creation test for Home. |
| src/app/pages/home/home.html | Adds placeholder template for Home. |
| src/app/pages/home/home.css | Adds stylesheet placeholder for Home. |
| src/app/layout/header/header.ts | Adds placeholder Header layout component. |
| src/app/layout/header/header.spec.ts | Adds basic creation test for Header. |
| src/app/layout/header/header.html | Adds placeholder template for Header. |
| src/app/layout/header/header.css | Adds stylesheet placeholder for Header. |
| src/app/layout/footer/footer.ts | Adds placeholder Footer layout component. |
| src/app/layout/footer/footer.spec.ts | Adds basic creation test for Footer. |
| src/app/layout/footer/footer.html | Adds placeholder template for Footer. |
| src/app/layout/footer/footer.css | Adds stylesheet placeholder for Footer. |
| src/app/app.ts | Imports and registers Header/Footer in the root component. |
| src/app/app.routes.ts | Defines the initial route map for pages and a wildcard 404 route. |
| src/app/app.html | Wraps routed content with header/footer app shell. |
| package.json | Adds lint script and ESLint-related dev dependencies. |
| package-lock.json | Locks newly added ESLint/angular-eslint dependency graph. |
| eslint.config.js | Adds ESLint flat config for TS + Angular templates (incl. accessibility rules). |
| angular.json | Registers angular-eslint schematics collection and adds a lint target. |
Comments suppressed due to low confidence (1)
package.json:14
- New ESLint 10 dependencies in the lockfile require Node
^20.19.0 || ^22.13.0 || >=24(e.g.eslintand@eslint/js). Since this repo doesn’t declare a Node engine, installs/lint runs can fail on older Node versions. Consider declaring a compatible Node version via theengines.nodefield (or otherwise pinning/documenting the required Node runtime).
"private": true,
"packageManager": "npm@10.9.3",
"dependencies": {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| <app-header></app-header> | ||
| <router-outlet></router-outlet> | ||
| <app-footer></app-footer> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.