Feat/hero - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Introduces a new Home “Hero” section as a dedicated Angular component, along with supporting styling and PWA/head metadata updates.
Changes:
- Extract hero markup into a new
Herocomponent and render it fromHome. - Add extensive hero interaction/animation styling (global + component CSS).
- Update
index.htmlhead metadata and add a web manifest + favicon assets.
Reviewed changes
Copilot reviewed 8 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles.css | Adds global hero interaction styles (CTA, socials, greeting, lettering, polaroid caption). |
| src/index.html | Updates document metadata, theme-color, favicon links, and manifest reference. |
| src/app/pages/home/sections/hero/hero.ts | Adds the new Hero Angular component. |
| src/app/pages/home/sections/hero/hero.html | Adds hero section markup (title, CTA, socials, imagery). |
| src/app/pages/home/sections/hero/hero.css | Adds component-scoped hero layout styling. |
| src/app/pages/home/home.ts | Imports and registers Hero in Home. |
| src/app/pages/home/home.html | Replaces inline hero section with <app-hero />. |
| src/app/pages/home/sections/hero/hero.spec.ts | Present but empty test file for the new component. |
| public/site.webmanifest | Adds PWA manifest configuration. |
| public/favicon.svg | Adds SVG favicon asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </div> | ||
| </div> | ||
| </section> | ||
| <app-hero /> |
Comment on lines
+77
to
+80
| .hero__title { | ||
| display: contents; | ||
| margin: 0; | ||
| } |
Comment on lines
+82
to
+88
| .hero__cta { | ||
| transition: | ||
| background-color 180ms ease-out, | ||
| transform 180ms cubic-bezier(0.2, 0.8, 0.2, 1), | ||
| box-shadow 180ms ease-out; | ||
| } | ||
|
|
Comment on lines
+89
to
+106
| @media (hover: hover) and (pointer: fine) { | ||
| a.hero__cta:hover { | ||
| transform: translate(2px, 4px); | ||
| box-shadow: none; | ||
| border-color: #f8f9fa; | ||
| background-color: #f87a55; | ||
| color: #f8f9fa; | ||
| } | ||
| } | ||
|
|
||
| a.hero__cta:active { | ||
| transform: translate(2px, 4px); | ||
| box-shadow: none; | ||
| border-color: #f8f9fa; | ||
| background-color: #f87a55; | ||
| color: #f8f9fa; | ||
| transition-duration: 80ms; | ||
| } |
Comment on lines
+4
to
+9
| @Component({ | ||
| selector: 'app-hero', | ||
| imports: [RouterLink], | ||
| templateUrl: './hero.html', | ||
| styleUrl: './hero.css', | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.