Feat/about - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “About” section to the Home page and introduces a reusable CTA link component to standardize CTA styling/behavior across sections. It also refreshes some hero styling and brings in new About-related SVG assets, while removing multiple Angular unit test specs.
Changes:
- Introduce
app-cta-linkshared UI component and migrate Hero CTA usage to it. - Add a new Home “About” section with availability cards and supporting styles/assets.
- Remove existing Angular unit test spec files for multiple pages/layout/app.
Reviewed changes
Copilot reviewed 20 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles.css | Removes global .hero__cta styles (CTA styling shifts to component-scoped CSS). |
| src/app/shared/ui/cta-link/cta-link.ts | Adds new CTA link standalone component API (inputs for label/route/fragment/surface). |
| src/app/shared/ui/cta-link/cta-link.html | CTA link template using RouterLink + optional fragment. |
| src/app/shared/ui/cta-link/cta-link.css | Component-scoped CTA visuals (hover/active/focus/reduced-motion). |
| src/app/pages/home/sections/hero/hero.ts | Switches Hero imports from RouterLink to the new CtaLink component. |
| src/app/pages/home/sections/hero/hero.html | Replaces <a.hero__cta> with <app-cta-link> in the hero section. |
| src/app/pages/home/sections/hero/hero.css | Updates hero background styling and adjusts CTA sizing to work with the new component. |
| src/app/pages/home/sections/about/about.ts | Adds new About section component and availability card data. |
| src/app/pages/home/sections/about/about.model.ts | Defines the AvailabilityCard model. |
| src/app/pages/home/sections/about/about.html | Adds About section markup, CTA, and availability card rendering. |
| src/app/pages/home/sections/about/about.css | Adds About-specific styling and underline animation. |
| src/app/pages/home/home.ts | Registers About section in the Home page component imports. |
| src/app/pages/home/home.html | Renders the new <app-about /> section under the hero. |
| src/app/pages/project-detail/project-detail.spec.ts | Removes unit test spec file. |
| src/app/pages/privacy-policy/privacy-policy.spec.ts | Removes unit test spec file. |
| src/app/pages/not-found/not-found.spec.ts | Removes unit test spec file. |
| src/app/pages/legal-notice/legal-notice.spec.ts | Removes unit test spec file. |
| src/app/pages/home/home.spec.ts | Removes unit test spec file. |
| src/app/layout/footer/footer.spec.ts | Removes unit test spec file. |
| src/app/app.spec.ts | Removes unit test spec file. |
| public/assets/about/remote.svg | Adds About availability icon asset. |
| public/assets/about/relocation.svg | Adds About availability icon asset. |
| public/assets/about/location.svg | Adds About availability icon asset. |
| public/assets/about/about-title-underline.svg | Adds About title underline asset (includes embedded image data). |
Suppressed comments (1)
src/app/shared/ui/cta-link/cta-link.ts:16
fragmentis currently optional (input<string>()), which means it can beundefined.RouterLink'sfragmentinput is typicallystring | null, so defaulting tonullavoids undefined leaking into the directive API and plays nicer with strict template type-checking.
readonly route = input('/');
readonly fragment = input<string>();
readonly surface = input<'dark' | 'light'>('dark');
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
10
| background: var(--color-foreground); | ||
| color: var(--color-foreground); |
Comment on lines
+9
to
+12
| }) | ||
|
|
||
| //! note check again | ||
| export class CtaLink { |
Comment on lines
+3
to
+5
| [class.cta-link--on-light]="surface() === 'light'" | ||
| [routerLink]="route()" | ||
| [fragment]="fragment()" |
| }, | ||
| { | ||
| id: 'remote', | ||
| label: 'Open to work remote', |
Comment on lines
3
to
9
| import { Hero } from './sections/hero/hero'; | ||
| import { About } from './sections/about/about'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-home', | ||
| imports: [Hero], | ||
| imports: [Hero, About], | ||
| templateUrl: './home.html', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.