feat(header): add glass effect on scroll - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “glass” visual treatment to the site header after the user scrolls, by tracking scroll position in the header component and toggling a CSS modifier class to apply blur/shadow/border styling.
Changes:
- Added a scroll sentinel +
IntersectionObserverlogic to track whether the page has been scrolled. - Bound a
site-header--scrolledmodifier class in the template based on a newisScrolledsignal. - Introduced a dedicated
header.cssstylesheet and linked it viastyleUrl.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/layout/header/header.ts | Adds scroll state tracking with an IntersectionObserver and cleans it up on destroy. |
| src/app/layout/header/header.html | Adds a scroll sentinel element and toggles a CSS modifier class on the header when scrolled. |
| src/app/layout/header/header.css | Implements the “glass” styling (blur, border, shadow) for the scrolled header state, with reduced-motion handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+174
to
+192
| private observeScrollPosition(): void { | ||
| const view = this.document.defaultView; | ||
|
|
||
| if (!view) { | ||
| return; | ||
| } | ||
|
|
||
| this.scrollObserver = new view.IntersectionObserver((entries) => { | ||
| const [entry] = entries; | ||
|
|
||
| if (!entry) { | ||
| return; | ||
| } | ||
|
|
||
| this.isScrolled.set(!entry.isIntersecting); | ||
| }); | ||
|
|
||
| this.scrollObserver.observe(this.scrollSentinel().nativeElement); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.