fix(ui): themeable .kino root backdrop (--kino-bg) - #32
Merged
Conversation
The root was hardcoded background: black, which flashes through before the media/stage paints. Hosts embedding the player over a light surface had no way to override it. Expose --kino-bg (default black, so existing players are unchanged); consumers can set it via their stylesheet or the theme prop.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
kino | 7fbb908 | Commit Preview URL Branch Preview URL |
Jul 22 2026, 08:33 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
.kinoroot was hardcodedbackground: black. That backdrop shows before the media (or a scenes iframe) paints, so a player embedded over a light-theme page flashes black on load, with no way to override it.Exposes it as a
--kino-bgtoken (defaultblack), alongside the other overridable--kino-*visual tokens. Consumers can theme it via their own stylesheet or thethemeprop (e.g.--kino-bg: transparent).Compatibility
Default is
black, so every existing player renders identically. Patch release (changeset included).Notes
The karnstack app already ships an app-side override for the scenes stage (karnstack#143); this makes it a first-class kino primitive for any consumer.