data: salvage competitor-analysis pipeline from PR #27 (design dropped)

[kas1987]

Summary

Salvages only the competitor-analysis data/pipeline layer from PR #27 (feat/pdr-001-design-system-v2) into a clean branch. PR #27's competing visual design is intentionally dropped — per the reconciliation analysis, #34 (feat/howiezz-fe-design) is the canonical design. This branch is stacked on #34's base so the design + analysis PDRs carry through without duplication.

What this carries (data/analysis layer only)

6 pipeline scripts (pdr-001 versions, genuine competitor-analysis improvements):

• scripts/analyze_independent_groupings.py — Windows-safe path serialization (str() over .as_posix())
• scripts/build_competitor_catalog_taxonomy.py — sub-100cm height guards against partial regex matches, brand/material classification refinements, unavailable-competitor dedup
• scripts/build_independent_db.py — updated source docstring (+BestRealDoll)
• scripts/inspect_scrape.py — ROOT-relative path resolution
• scripts/print_report.py — ROOT-relative path resolution
• scripts/scrape_competitors.js — pipeline refactor (removed unused deep-dive path)

Deliberately NOT included

• PDR-001/PDR-010: design system v2 + full competitor analysis package #27's competing design — assets/site.css, all *.html, docs/pdr/PDR-001-luxury-design-system-v2.md. FE: Concierge Atlas frontend redesign (HZZ-FE-001..009 + premium intake) #34 wins.
• The agent-source-material docs and PDR-005/006/007/010 analysis briefs were verified byte-identical to this branch's base, so they are skipped (no duplication).

Integrity

• node --check scripts/scrape_competitors.js → OK
• python -m py_compile on all 5 salvaged .py scripts → OK

Recommendation

Once this and #34 land, PR #27 can be closed — its remaining value (this pipeline) is captured here, and its design is superseded by #34.

[gemini-code-assist]

Code Review

This pull request introduces a major frontend redesign of the ZELEX Atlas, adding a live configurator, a body comparison tool, a community hub, and an upgraded guided concierge intake form, alongside automated packaging and CI validation workflows. The code review identified several critical issues, notably a bug in the comparison state logic where exceeding the 4-body limit results in silent failures and incorrect analytics tracking across multiple pages. Additionally, the contact page currently ignores the configurator's customization parameters, trailing slashes in URLs break page-view tracking, a global focus style causes visual glitches on rounded elements, and a minor PEP 8 indentation violation exists in the Python sanity script.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

assets/site.js (122-129)

When the comparison list already contains 4 bodies, calling addCompareBody will append the new body to the array, but setCompareBodies will silently slice it back to 4 elements, discarding the newly added body. However, the function still returns added: true, which misleads the UI and analytics into thinking the body was successfully added. We should check the limit before attempting to add.

  function addCompareBody(bodyCode) {
    const code = String(bodyCode || '').trim();
    if (!code || code === '.') return { added: false, bodies: getCompareBodies() };
    const cur = getCompareBodies();
    if (cur.includes(code)) return { added: false, bodies: cur };
    if (cur.length >= 4) return { added: false, bodies: cur };
    const next = setCompareBodies(cur.concat(code));
    return { added: true, bodies: next };
  }

body.html (287-294)

The comparison button is marked as done and updated to "Added to Compare" even if the limit of 4 bodies has been exceeded and the body was not actually added. We should conditionally update the UI based on result.added and notify the user if the limit is reached.

    compareBtnEl.addEventListener('click', () => {
      const result = ZX.addCompareBody(bc);
      if (result.added) {
        compareBtnEl.classList.add('done');
        compareBtnEl.textContent = 'Added to Compare';
        ZX.track('compare_add', { body_code: bc, family: family || '', series: series || '', compare_count: result.bodies.length, context: 'body_detail', source_page: 'body' });
      } else if (result.bodies.includes(bc)) {
        compareBtnEl.classList.add('done');
        compareBtnEl.textContent = 'Added to Compare';
      } else {
        alert('Comparison list is full (maximum 4 bodies).');
      }
    });

character.html (670-675)

Similar to the body detail page, the comparison button here is marked as done even if the limit of 4 bodies is exceeded. We should check result.added and alert the user if the limit is reached.

    compareCharBtn.addEventListener('click', () => {
      const result = ZX.addCompareBody(c.body_code);
      if (result.added) {
        compareCharBtn.classList.add('done');
        compareCharBtn.textContent = 'Added to compare';
        trackCompareAdd(result, 'character_detail');
      } else if (result.bodies.includes(c.body_code)) {
        compareCharBtn.classList.add('done');
        compareCharBtn.textContent = 'Added to compare';
      } else {
        alert('Comparison list is full (maximum 4 bodies).');
      }
    });

browse.html (265-299)

The addCompareFromBrowse function duplicates the localStorage comparison logic instead of reusing the shared ZX.addCompareBody helper. This leads to the same silent failure where the button is marked as "Added to Compare" even if the limit of 4 bodies is exceeded. We should refactor this to use the shared helper.

function addCompareFromBrowse(characterId) {
  if (!_model || !_model.byId || !_model.byId[characterId]) return;
  const c = _model.byId[characterId];
  const code = c.body_code || '';
  if (!code) return;

  const result = ZX.addCompareBody(code);
  if (result.added) {
    refreshCompareQuick();

    ZX.track('compare_set_changed', {
      action: 'add',
      compare_count: result.bodies.length,
      body_codes: result.bodies.join(','),
      context: 'browse_list',
      source_page: 'browse'
    });

    ZX.track('compare_add', {
      body_code: code,
      character_id: c.character_id,
      family: (c.body && c.body.family) ? c.body.family : '',
      series: c.series || '',
      compare_count: result.bodies.length,
      context: 'browse_list',
      source_page: 'browse'
    });

    const btn = document.querySelector('[data-compare-char="' + characterId + '"]');
    if (btn) {
      btn.classList.add('done');
      btn.textContent = 'Added to Compare';
    }
  } else if (result.bodies.includes(code)) {
    const btn = document.querySelector('[data-compare-char="' + characterId + '"]');
    if (btn) {
      btn.classList.add('done');
      btn.textContent = 'Added to Compare';
    }
  } else {
    alert('Comparison list is full (maximum 4 bodies).');
  }
}

compare.html (223-231)

In compare.html, adding a body when the limit of 4 is already reached will silently discard the new body due to slice(0, 4), but still trigger the compare_add and compare_set_changed analytics events with the unsaved body code. We should guard against exceeding the limit and alert the user.

  document.getElementById('addBody').onclick = () => {
    const code = select.value;
    const cur = selectedCodes().filter(Boolean);
    if (cur.includes(code)) return;
    if (cur.length >= 4) {
      alert('Comparison list is full (maximum 4 bodies).');
      return;
    }
    const next = cur.concat(code);
    saveCodes(next);
    ZX.track('compare_set_changed', { action: 'add', compare_count: next.length, body_codes: next.join(','), context: 'compare', source_page: 'compare' });
    ZX.track('compare_add', { body_code: code, compare_count: next.length, context: 'compare', source_page: 'compare' });
    paint(m);
  };

contact.html (1027-1030)

The configurator page passes config_summary in the URL query string, but the contact page completely ignores it. This means the user's customized options (skin, eyes, hair, realism) are lost when they navigate to the contact page. We should parse config_summary and apply it to the FIT state.

    if (typeof FIT !== 'undefined') {
      var configSummary = ZX.qs('config_summary');
      if (configSummary) {
        var configObj = {};
        configSummary.split(';').forEach(function(part) {
          var kv = part.split('=');
          if (kv.length === 2) configObj[kv[0]] = kv[1];
        });
        if (configObj.realism) {
          var rIdx = ['Natural','Soft','Balanced','Bold','Dramatic'].indexOf(configObj.realism);
          if (rIdx !== -1) FIT.pick('realism', rIdx);
        }
        if (configObj.skin) FIT.pick('skin', configObj.skin);
        if (configObj.eye) FIT.pick('eye', configObj.eye);
        if (configObj.hair) FIT.pick('hair', configObj.hair);
      }
      FIT.refresh();
    }

assets/site.js (180-184)

If the browser path ends with a trailing slash (e.g., /browse/), location.pathname.split('/').pop() returns an empty string, causing the page view to fall back to 'index.html'. We should filter out empty segments to reliably extract the actual page name.

    const segments = location.pathname.split('/').filter(Boolean);
    const lastSegment = segments[segments.length - 1] || 'index.html';
    const pageName = lastSegment.toLowerCase();
    track('page_view', {
      context: 'navigation',
      source_page: pageName.replace('.html', '')
    });

assets/site.css (72)

Setting border-radius: 2px globally on :focus-visible overrides the original border-radius of any focused element. For example, rounded buttons (border-radius: var(--r-pill)) or cards (border-radius: var(--r-lg)) will suddenly snap to sharp 2px corners when focused, causing a jarring visual glitch. We should remove this property and let the outline naturally follow the element's existing border radius.

:focus-visible{outline:2px solid var(--gold);outline-offset:3px}

scripts/analytics_event_sanity.py (207-211)

The indentation on lines 208 and 209 uses 6 spaces instead of the standard 8 spaces, violating PEP 8 style guidelines for consistent 4-space indentation.

    if summary.get("total_events", 0) < args.min_total_events:
        failures.append(
            f"total_events below minimum: {summary.get('total_events', 0)} < {args.min_total_events}"
        )

References

1. Consistent indentation of 4 spaces per indentation level is required by PEP 8. ^(link)

[Copilot]

Pull request overview

This PR introduces a broader “ops + governance + community” slice (community hub pages, CI validators/guards, v2 HTML packaging determinism, analytics sanity tooling, and PDR/ticket recovery docs) while also carrying competitor-analysis pipeline script updates (path handling, taxonomy scrape refinements, and competitor scrape refactors).

Changes:

• Add data-driven Community + Community Events pages, plus community JSON contracts, validators, and CI enforcement.
• Add deterministic v2 HTML/ packaging automation (manifest + sha256) and a CI freshness guard.
• Update competitor-analysis scripts (Python + Node) for path portability and scrape/taxonomy logic changes, and add analytics sanity suite tooling/docs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
v2 HTML/manifest.sha256	Checksums for packaged HTML snapshot.
v2 HTML/manifest.json	Packaged HTML manifest (hashes/sizes/mtime).
v2 HTML/community.html	Packaged copy of community hub page.
v2 HTML/community-events.html	Packaged copy of community events page.
scripts/sync_community_channels_from_reference.ps1	Sync/check-mode for community channels JSON.
scripts/scrape_competitors.js	Competitor scrape pipeline refactor.
scripts/scaffold_community_event.ps1	Safe appender for community events entries.
scripts/run_analytics_sanity.ps1	Wrapper to run analytics sanity checker.
scripts/run_analytics_sanity_suite.ps1	Positive/negative analytics fixture suite runner.
scripts/run_analytics_sanity_ci_parity.ps1	CI parity harness for analytics suite behavior.
scripts/refresh_v2_html.ps1	Generates v2 HTML snapshot + manifest/hash.
scripts/print_report.py	ROOT-relative path resolution.
scripts/inspect_scrape.py	ROOT-relative path resolution.
scripts/build_independent_db.py	Source docstring update.
scripts/build_competitor_catalog_taxonomy.py	Scrape/taxonomy refinements + unavailable dedupe.
scripts/analyze_independent_groupings.py	Windows-safe path serialization in output JSON.
README.md	Docs updates (analytics config + PDR source-of-truth notes).
docs/tickets/HZZ-FE-013-small-label-contrast-pass.md	New FE ticket doc.
docs/tickets/HZZ-FE-012-reconcile-families-series-copy.md	New FE ticket doc.
docs/tickets/HZZ-FE-011-fix-mobile-horizontal-overflow.md	New FE ticket doc.
docs/tickets/HZZ-FE-010-verify-browse-grid-headless-load.md	New FE ticket doc.
docs/tickets/HZZ-FE-009-visual-qa-screenshot-review.md	New FE ticket doc.
docs/tickets/HZZ-FE-008-mobile-navigation-and-cta-pass.md	New FE ticket doc.
docs/tickets/HZZ-FE-007-improve-browse-and-family-ux.md	New FE ticket doc.
docs/tickets/HZZ-FE-006-design-concierge-intake-ux.md	New FE ticket doc.
docs/tickets/HZZ-FE-005-improve-quiz-match-result-funnel.md	New FE ticket doc.
docs/tickets/HZZ-FE-004-upgrade-character-detail-conversion-ux.md	New FE ticket doc.
docs/tickets/HZZ-FE-003-design-body-compare-ux.md	New FE ticket doc.
docs/tickets/HZZ-FE-002-refine-luxury-design-system-v2.md	New FE ticket doc.
docs/tickets/HZZ-FE-001-redesign-homepage-as-concierge-atlas-landing.md	New FE ticket doc.
docs/tickets/HZZ-FE-000-recover-frontend-pdr-source-of-truth.md	New FE ticket doc.
docs/research/v2-packaging-runbook.md	Runbook for v2 HTML packaging + CI freshness guard.
docs/research/SWOT-community-gap-2026-06-16.md	SWOT/gap writeup for community hub addition.
docs/research/community-kb-linkage.md	Notes tying community UI to KB provenance.
docs/research/community-data-contract.md	Contributor contract for community JSON data.
docs/prompts/claude-design/HZZ-FE-008-prompt.md	Prompt file for FE-008.
docs/prompts/claude-design/HZZ-FE-007-prompt.md	Prompt file for FE-007.
docs/prompts/claude-design/HZZ-FE-006-prompt.md	Prompt file for FE-006.
docs/prompts/claude-design/HZZ-FE-005-prompt.md	Prompt file for FE-005.
docs/prompts/claude-design/HZZ-FE-004-prompt.md	Prompt file for FE-004.
docs/prompts/claude-design/HZZ-FE-003-prompt.md	Prompt file for FE-003.
docs/prompts/claude-design/HZZ-FE-002-prompt.md	Prompt file for FE-002.
docs/prompts/claude-design/HZZ-FE-001-prompt.md	Prompt file for FE-001.
docs/prompts/claude-design/CLAUDE-DESIGN-BASE-CONSTRAINTS.md	Base constraints for Claude Design tasks.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/work_queue.json	Recovery-pack work queue.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/scripts/LOCAL_PR_COMMANDS.md	Local PR command notes for recovery.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/README.md	Recovery pack overview and sequence.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/research/source-log-template.md	Source log template.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/research/competitor-family-coverage-matrix-template.csv	Matrix CSV template.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-010-competitor-family-coverage-roi-validation.md	Recovery-pack PDR-010.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-009-six-family-product-taxonomy.md	Recovery-pack PDR-009.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-008-analytics-event-taxonomy.md	Recovery-pack PDR-008.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-007-seo-og-structured-data-build-layer.md	Recovery-pack PDR-007.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-006-concierge-intake-crm-ready-leads.md	Recovery-pack PDR-006.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-005-character-detail-premium-conversion.md	Recovery-pack PDR-005.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-004-quiz-match-score-funnel.md	Recovery-pack PDR-004.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-003-body-compare-tool.md	Recovery-pack PDR-003.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-002-homepage-concierge-landing.md	Recovery-pack PDR-002.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-001-luxury-design-system-v2.md	Recovery-pack PDR-001.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/pdr/PDR-000-recovery-and-source-of-truth.md	Recovery-pack PDR-000.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/handoffs/agent-handoff-packets.md	Role handoff packets.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/docs/handoffs/agent-dispatch-board.md	Dispatch board.
docs/pdr/recovery-pack/HowieZZ_PDR_Recovery_Pack/command-center/Command-Center-sync-plan.md	Command Center sync plan.
docs/pdr/PDR-implementation-audit.md	Implementation audit doc.
docs/pdr/PDR-FE-009-visual-qa-screenshot-review.md	FE QA PDR doc.
docs/pdr/PDR-FE-009-live-interaction-evidence.md	Live QA evidence capture.
docs/pdr/PDR-FE-008-mobile-navigation-cta-pass.md	FE-008 PDR doc.
docs/pdr/PDR-FE-007-browse-family-ux.md	FE-007 PDR doc.
docs/pdr/PDR-FE-006-concierge-intake.md	FE-006 PDR doc.
docs/pdr/PDR-FE-005-quiz-match-results.md	FE-005 PDR doc.
docs/pdr/PDR-FE-004-character-detail-conversion.md	FE-004 PDR doc.
docs/pdr/PDR-FE-003-body-compare-ux.md	FE-003 PDR doc.
docs/pdr/PDR-FE-002-luxury-design-system-v2.md	FE-002 PDR doc.
docs/pdr/PDR-FE-001-homepage-concierge-landing.md	FE-001 PDR doc.
docs/pdr/PDR-FE-000-frontend-source-of-truth-gate.md	Frontend PDR source-of-truth gate.
docs/pdr/PDR-analytics-smoke-test-checklist.md	Analytics smoke test checklist.
docs/pdr/PDR-analytics-sanity-thresholds.missing-keys.json	Negative fixture config.
docs/pdr/PDR-analytics-sanity-thresholds.json	Threshold config.
docs/pdr/PDR-analytics-sanity-thresholds.invalid.json	Negative fixture config.
docs/pdr/PDR-analytics-sample-events.ndjson	Analytics positive fixture.
docs/pdr/PDR-analytics-sample-events-low-attribution.ndjson	Analytics negative fixture.
docs/pdr/PDR-analytics-sample-events-broken.ndjson	Analytics negative fixture.
docs/pdr/PDR-analytics-event-taxonomy.md	Analytics taxonomy doc.
docs/pdr/PDR-analytics-dashboard-handoff-runbook.md	Dashboard handoff runbook.
docs/pdr/PDR-analytics-dashboard-cookbook.md	Dashboard cookbook.
docs/howie-ceo-package/README.md	CEO package index.
docs/howie-ceo-package/05-howie-decision-log-template.md	Decision log template.
docs/howie-ceo-package/04-howie-deep-dive-guide.md	Deep-dive guide.
docs/howie-ceo-package/03-like-kind-manufacturing-scenarios.md	Manufacturing scenario brief.
docs/howie-ceo-package/03-kpi-scoreboard-template.md	KPI template.
docs/howie-ceo-package/02-team-execution-guide.md	Execution guide.
docs/howie-ceo-package/01-dedicated-brief-library.md	Brief library index.
docs/howie-ceo-package/00-howie-ceo-command-brief.md	CEO command brief.
docs/handoffs/TASK-HZZ-P2-012-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-011-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-010-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-009-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-008-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-007-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-006-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-005-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-004-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-002-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P2-001-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P1-003-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P1-002-kickoff.md	Task kickoff doc.
docs/handoffs/TASK-HZZ-P1-001-kickoff.md	Task kickoff doc.
docs/design-packages/premium-intake/README.md	Premium intake design package doc.
docs/agents/customization-options-agent.md	Agent responsibilities doc.
db/community_events.json	Community events data.
db/community_channels.json	Community channels + provenance refs.
CONTRIBUTING.md	PDR authority/task gating guidance.
community.html	Community hub page.
community-events.html	Community events page.
CODEX.md	Codex PDR_PATH gate doc.
CLAUDE.md	Claude PDR_PATH gate doc.
body.html	“Add to Compare” wiring on body page.
AGENTS.md	Agent execution contract doc.
404.html	Canonical/OG metadata additions.
.gitignore	Ignore rules updates (QA screenshots, zip allowlist).
.github/workflows/ci.yml	CI steps for community/packaging/analytics guards.
.github/scripts/validate-site.mjs	Auto-discover root HTML pages for validation.
.github/scripts/validate-pdr-path-task-files.mjs	Enforce pdr_path presence/existence in task docs.
.github/scripts/validate-community-events-data.mjs	Validate community events schema/targets.
.github/scripts/validate-community-data.mjs	Validate community channels schema/provenance.
.cursor/rules/pdr-path-required.mdc	Cursor rule enforcing PDR_PATH in prompts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.