This repository was archived by the owner on May 12, 2021. It is now read-only.
Skip routes with ipv6 gateway#57
Merged
Merged
Conversation
sboeuf
approved these changes
Mar 14, 2018
|
Thanks for cherry picking this from github.com/containers/virtcontainers @amshinde ! |
amshinde
force-pushed
the
skip-ipv6-gateway
branch
from
b035040 to
c28407d
Compare
jodh-intel
approved these changes
Mar 14, 2018
Member
Author
|
Thanks @sboeuf. I have added the #Fixes line. |
Member
Author
|
@sboeuf @jodh-intel @grahamwhaley CI failing because of SCSI changes. We may need to force merge this one as well. |
|
@amshinde could you please rebase this PR, the CI should pass now. |
We ignore routes that have an ipv6 destination, since kata agent does not have support for ipv6 currently. We should do the same for default route that has an ipv6 gateway address. We need to revisit this once we start adding support for ipv6. Fixes kata-containers#58 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
We ignore routes that have an ipv6 destination, since hyperstart agent does not have support for ipv6 currently. We should do the same for default route that has an ipv6 gateway address. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
amshinde
force-pushed
the
skip-ipv6-gateway
branch
from
c28407d to
b6e6924
Compare
Member
Author
|
Yup rebased and pushed @sboeuf |
|
Cool thanks @amshinde |
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ipv6 is not yet supported, we should skip all ipv6 routes including those that have an ipv6 gatway.