Feature: automatic item dup - #138
Merged
Merged
Conversation
Previously, item implementors were expected to handle copy/dup for custom items. With the addition of govuk_attachment_field we broke support for optional attachments, so rather than fix once here and expect consumers to mimic the fix, we're using ActiveStorage reflection to handle duplication automatically. This should help simplify custom items.
Provides dup support for item associations: - ActiveStorage attachments defined with has_*_attached - ActionText attachments defined with has_rich_text - Custom associations declared with `duplicates_association` Items no longer need to define `initialize_dup` unless they have custom associations. `rubocop-katalyst` has related cop to check that owned associations call `duplicates_association`.
AlanCornthwaiteKatalyst
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides dup support for item associations:
duplicates_associationItems no longer need to define
initialize_dupunless they havecustom associations.
rubocop-katalysthas related cop to check thatowned associations call
duplicates_association.