Removed: Unused code and fixed naming - #74
Merged
Conversation
Draft
soysudhanshu
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every compiled view had
<?php ##PATH ## ?>appended to it. The path interpolation that once filled the marker was dropped with the ViewFinder refactor, so all it does now is write an empty comment into each cached file, and nothing reads it back.The rest is naming and dead declarations.
viewExists()carried abool $isComponentparameter it never read, the check is done withinstanceof.ERROR_INVALID_CONFIGis referenced nowhere, the constructor throws the more specific path messages instead. The auth message pointed atConfig::setAuth, which does not exist, the method issetAuthCallback(). The local$compliedincompile()is now$compiled, matching$compiledPathbeside it and thesaveCache()parameter it feeds.Dropping the
viewExists()parameter changes a public signature. Nothing in the library passes it, but it is the one change here that can reach a consumer.