Add browser CI workflow - #23
Conversation
|
@codex review |
Coverage Report for CI Build 33391881168Coverage remained the same at 96.528%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f52f4e5f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
The new browser/Makefile contains invalid recipe indentation that will break make, and the new publish workflow uploads a non-existent artifact path.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a Playwright-driven browser test runner and a new “Browser CI” GitHub Actions workflow to execute the existing Mocha suite in headless Chromium, aligning CI coverage with browser behavior.
Changes:
- Add a
Browser CIworkflow that runsmake -C browser installandmake -C browser teston pushes tomainand on manual dispatch. - Introduce a Playwright CLI runner (
browser/tests.cli.mjs) and updatebrowser/tests.htmlto report completion viawindow.mochaStats. - Misc: update CI badge branches to
main, bump a few devDependency versions, removebower.json, and add a new publish workflow.
File summaries
| File | Description |
|---|---|
| README.md | Updates CI/coverage badges to track the main branch. |
| package.json | Bumps devDependency versions (Node types, mocha, terser). |
| browser/tests.html | Adjusts browser test harness and completion reporting for Playwright runner. |
| browser/tests.cli.mjs | Adds Playwright-based runner to execute the Mocha browser suite and fail CI on errors/empty runs. |
| browser/Makefile | Adds browser-specific make targets for transient Playwright install and running browser tests. |
| bower.json | Removes legacy Bower metadata file. |
| .gitignore | Ignores .Thumbs and un-ignores the new tracked browser/tests.cli.mjs despite *.mjs ignore. |
| .github/workflows/publish.yml | Adds a tag-driven publish workflow with artifact handoff between build and stage jobs. |
| .github/workflows/nodejs.yml | Updates action versions for checkout/setup-node. |
| .github/workflows/browser.yml | Adds the new Browser CI workflow to run Playwright-backed browser tests. |
Review details
Suppressed comments (1)
browser/Makefile:27
- Make recipes must start with a tab; this target currently uses spaces, which will cause
maketo error with "missing separator".
clean:
@: # NOP
- Files reviewed: 9/10 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| name: Publish | ||
|
|
||
| # Releases are cut by pushing a version tag, so ordinary pushes never reach | ||
| # npm. The staged publish below still leaves the version invisible until a | ||
| # maintainer approves it with 2FA. | ||
| on: | ||
| push: | ||
| tags: [ "1.*.*" ] |
|
@codex review |
There was a problem hiding this comment.
🟡 Changes recommended
The new browser workflow and Makefile have issues that will break CI (missing dependency install and an invalid Make recipe line), and the publish workflow references non-existent artifact action major versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
browser/Makefile:27
cleantarget recipe is indented with spaces instead of a tab, which will causemaketo fail with "missing separator".
clean:
@: # NOP
- Files reviewed: 9/10 changed files
- Comments generated: 1
- Review effort level: Lite
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Browser CIworkflow for pushes tomainand manual runs, byte-identical to the sibling packages' workflowtests.cli.mjsrunner (also byte-identical): completion is reported throughwindow.mochaStats, an unfinished page times out, and an empty run fails with "Mocha ran no tests"