Skip to content

Conversation

@Rusteam
Copy link

@Rusteam Rusteam commented Feb 7, 2024

Closed #54.

Can you please check if the changes make sense? I'll update the docs in the meantime.

I've tested on macos, it works.

@Rusteam Rusteam changed the title [wip] add Leet open command to open current question in browser add Leet open command to open current question in browser Feb 7, 2024
@kawre
Copy link
Owner

kawre commented Feb 8, 2024

Logic should go inside the open function because it's not related to the console

@Rusteam
Copy link
Author

Rusteam commented Feb 8, 2024

Can you point me to a specific file?

@Rusteam
Copy link
Author

Rusteam commented Feb 9, 2024

@kawre fixed all

@kawre kawre merged commit 1dda6e5 into kawre:master Feb 13, 2024
@kawre
Copy link
Owner

kawre commented Feb 13, 2024

Changed it back to os.execute since i didn't know that vim.cmd will log the command executed. Ideally it should use plenary jobs since they are non blocking, but for some reason they don't work well on windows.

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Leet open to open the current question in browser

2 participants