[Lazarus revival] Add deprecation warning to "Referrer" special-casing - #2
Draft
kax168 wants to merge 3 commits into
Draft
[Lazarus revival] Add deprecation warning to "Referrer" special-casing#2kax168 wants to merge 3 commits into
kax168 wants to merge 3 commits into
Conversation
re: expressjs#3951 Test plan: `npm test`
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
kax168
pushed a commit
to kax168/lazarus
that referenced
this pull request
Jul 19, 2026
…ies) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer Briefing: Add deprecation warning to "Referrer" special-casing
What this PR was trying to do
Add an Express deprecation warning when
req.get()relies on the historicalReferer/Referrerspecial-casing, as discussed in issue expressjs#3951.What changed in the repo since it died
The repository has changed substantially since PR expressjs#4106. Upstream now already includes
depdand usesnode:net; the revival reconciles those differences and merges cleanly with currentorigin/master. No listed intervening commit directly supersedes this deprecation.What Lazarus changed to revive it
Rebased the original work onto current
origin/master, preserved the deprecation behavior and original authorship, flattened an obsolete historical merge, and omitted the redundant dependency commit becausedepdis already present upstream.LAZARUS_TASK.mdremains untracked and untouched.Test evidence
Risk assessment
Risk appears low and localized to request-header lookup behavior.
npm run lintpassed, and post-revivalnpm testpassed with 1,260 tests. The baseline run had 1,233 passing and onesocket hang upfailure in an unrelatedres.format()negotiation test; no further evidence about that transient failure is available.Credits
Originally contributed by @rileyjshaw.
Original PR: expressjs#4106
Original author: @rileyjshaw