fix: release pipeline + 4-digit version support (v0.8.10)#34
Merged
Conversation
check_structural_fitness() used `declare -A` and check_doc_inventory() used `local -A`, both requiring bash 4+. Stock macOS ships bash 3.2, causing the script to crash silently and skip check_unprocessed() and check_mode(). Replaced with string-based key=value helpers (_kv_get, _kv_set, _kv_keys) and linear search helpers (_is_root_doc, _is_project_doc). Fixes 3 pre-existing test failures.
Version validation regex in update-check tightened from the loose ^[0-9]+\.[0-9.]+$ (accepted malformed versions like 1..2) to ^[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?$ (enforces exactly X.Y.Z or X.Y.Z.W), matching the roadmap-audit pattern. Added comment explaining the permanent gist bridge for pre-0.8.8.1 installs.
16 new tests: semver 4-digit comparisons (5), regex validation for valid and invalid versions (14), update-check upgrade detection with MICRO versions (2). Fixed stale setup test expectations (2→3 default skills, 3→4 with --with-native). 45 tests, 0 failures.
Creates annotated git tags (vX.Y.Z.W) automatically when VERSION changes on merge to main. Idempotent: skips if tag already exists. Validates VERSION format before tagging. Uses default GITHUB_TOKEN with contents:write.
README now defines MAJOR.MINOR.PATCH.MICRO semantics with examples. Replaced stale gist-migration example in roadmap skill with generic example.
kbitz
added a commit
that referenced
this pull request
Apr 24, 2026
* fix: replace bash 4+ associative arrays with bash 3-compatible helpers check_structural_fitness() used `declare -A` and check_doc_inventory() used `local -A`, both requiring bash 4+. Stock macOS ships bash 3.2, causing the script to crash silently and skip check_unprocessed() and check_mode(). Replaced with string-based key=value helpers (_kv_get, _kv_set, _kv_keys) and linear search helpers (_is_root_doc, _is_project_doc). Fixes 3 pre-existing test failures. * fix: tighten version regex and add gist bridge comment Version validation regex in update-check tightened from the loose ^[0-9]+\.[0-9.]+$ (accepted malformed versions like 1..2) to ^[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?$ (enforces exactly X.Y.Z or X.Y.Z.W), matching the roadmap-audit pattern. Added comment explaining the permanent gist bridge for pre-0.8.8.1 installs. * test: add 4-digit version and update-check tests 16 new tests: semver 4-digit comparisons (5), regex validation for valid and invalid versions (14), update-check upgrade detection with MICRO versions (2). Fixed stale setup test expectations (2→3 default skills, 3→4 with --with-native). 45 tests, 0 failures. * feat: auto-tag GitHub Action on VERSION change Creates annotated git tags (vX.Y.Z.W) automatically when VERSION changes on merge to main. Idempotent: skips if tag already exists. Validates VERSION format before tagging. Uses default GITHUB_TOKEN with contents:write. * docs: add versioning section to README, update roadmap example README now defines MAJOR.MINOR.PATCH.MICRO semantics with examples. Replaced stale gist-migration example in roadmap skill with generic example. * chore: bump version and changelog (v0.8.10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release pipeline fix: Three issues, one root cause. The update-check system was silently stuck for installed copies, version validation was too loose, and the public repo had zero git tags.
Infrastructure
auto-tag.yml) creates annotated git tags automatically when VERSION changes on merge to main. Idempotent, validates format, uses default GITHUB_TOKEN.Bug fixes
bin/update-checkto reject malformed versions (double dots, trailing dots, 5+ segments). Now matches thebin/roadmap-auditpattern.bin/roadmap-audit: replaced bash 4+ associative arrays (declare -A,local -A) with bash 3-compatible helpers. Stock macOS (bash 3.2) was crashing, silently skippingcheck_unprocessed()andcheck_mode().Documentation
bin/update-checkexplaining why the old gist URL must be kept alive.Test Coverage
Tests: 128 total (45 update + 83 roadmap-audit), 0 failures.
16 new tests added: semver 4-digit comparisons, regex validation, update-check upgrade detection.
Pre-Landing Review
No issues found. 2 adversarial findings auto-fixed (VERSION format validation in auto-tag Action, tighter test assertion).
Post-merge manual step
Update gist
511b8a4861f7b4df3a7fedd42911c701to match VERSION so pre-0.8.8.1 installs can discover the upgrade.Test plan