Merged
Conversation
Merged
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
sahil-lakhwani
force-pushed
the
args_type_change
branch
from
f488031 to
6ee38b9
Compare
PrasadG193
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sahil-lakhwani sahilakhwani@gmail.com
The
Argsfield in App is currentlymap[string]string, so values always arestringtype`. This may post challenges in the code where the actual type of the argument value is needed.Changing it to empty
map[string]interfcae{}so that the code can type assert it to the actual type.Have tested kbrew helm installations with args after this change.