Merged
Conversation
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
44b5686 to
4ee69f2
Compare
PrasadG193
reviewed
May 19, 2021
Comment on lines
+250
to
+252
| case string: | ||
| v = fmt.Sprintf("\"%s\"", v) | ||
| } |
Member
There was a problem hiding this comment.
Please add a default case? What is the expected behavior if v.Type is not string? Should we fail here?
Contributor
Author
There was a problem hiding this comment.
The yq library expects just the strings to be quoted.
Signed-off-by: sahil-lakhwani <sahilakhwani@gmail.com>
PrasadG193
approved these changes
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ability for the recipe authors to patch raw app yamls by passing args
The args should follow a format of :
<kind>.<name>.<fieldPath>: <value>where
fieldPathis the path of the field to be patchedThe value has to be typed - for example, string should be quoted.
Example:
Consists of #69 and #70 , so to be merged after them