CI: release rockspec for Lua upon release - #299
Merged
Conversation
Signed-off-by: Jakob Beckmann <f4z3r-github@pm.me>
Signed-off-by: Jakob Beckmann <f4z3r-github@pm.me>
Contributor
Author
|
I currently only publish the rock as a source tar. This means that clients will still need to have a Rust toolchain installed when installing the rock. In the future we could also release a binary rock that already contains the dynamic library binary so that a Rust toolchain is not needed. However, this means that we would need to publish various versions of the rock for different OS/CPU architectures. I think for now this is fine as a source rock. I can create a ticket to change this to binary rocks for a future enhancement. |
Contributor
|
LGTM. Thank you very much; I'll configure the API key a bit later. |
Contributor
Author
|
@Peefy perfect, you can then publish the 0.12.4 version by simply locally running: cd lua/
luarocks upload kcl_lib-0.12.4-1.rockspec --temp-key=<api-key> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following must be done for the LuaRocks publishing to work before publishing a new release on GH:
kcl_lib-<version>-1.rockspec.package_versionin the rockspec.Right now the following would need to be done to ensure this can be published:
kcl-langto represent the GH org).LUAROCKS_API_KEY.@Peefy I can create the account and generate the API key if you want and then send them to you somehow. However it probably makes more sense that you do this as I don't have permissions to update secrets in this repository and it makes sense that you control the kcl-lang account on LuaRocks IMO.