Skip to content

Add EtcdConfig.Prefix - #262

Merged
kcp-ci-bot merged 4 commits into
kcp-dev:mainfrom
ntnn:etcd-prefix
Jul 27, 2026
Merged

Add EtcdConfig.Prefix#262
kcp-ci-bot merged 4 commits into
kcp-dev:mainfrom
ntnn:etcd-prefix

Conversation

@ntnn

@ntnn ntnn commented Jul 26, 2026

Copy link
Copy Markdown
Member

7<!--

Thanks for creating a pull request!
If this is your first time, please make sure to review CONTRIBUTING.md.

-->

Summary

Adds EtcdConfig.Prefix resulting in --etcd-prefix for kcp components.
Also added for cache-server although that needs kcp-dev/kcp#4292 to be actually honoured :D

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #

Release Notes

Support setting `--etcd-prefix` for shards and cache-server

ntnn added 4 commits July 26, 2026 16:47
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2026

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2026
@kcp-ci-bot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 11d11fee99f23df51f0ef7f1ca2b700ac2058423

@kcp-ci-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2026
@kcp-ci-bot
kcp-ci-bot merged commit 268c010 into kcp-dev:main Jul 27, 2026
14 checks passed
@ntnn
ntnn deleted the etcd-prefix branch July 27, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants