deduplicate URL path for workspacemigration VW - #4239
Merged
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com Signed-off-by: Christoph Mewes <christoph@kubermatic.com>
kcp-ci-bot
added
release-note-none
Contributor
Author
|
/retest |
Contributor
|
Could be worse. /lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 9715d4f616ae95a0da7ff004bc65142d9a6069b3 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gman0 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Contributor
Author
|
/retest |
github-project-automation
Bot
moved this to Done
in Platform Mesh & Kube Projects - Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes a duplicate of the URL. Simple stuff. I chose this way because there is precedence: pkg/server already uses
initializingworkspaces.URLFor(), i.e. the server already uses code from the virtual workspaces.What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #4204
Release Notes