detect kcp connection failures via typed errors - #4265
Conversation
Signed-off-by: Nikita Rudakov <nikita.rudakov@sap.com>
|
Hi @nuromirg. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Nikita Rudakov <nikita.rudakov@sap.com>
mjudeikis
left a comment
There was a problem hiding this comment.
/lgtm
/approve
thanks for this!
|
LGTM label has been added. DetailsGit tree hash: 12b82ba58f1199927872c0696d003c2d7d98feca |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
kubectl kcp quickstartnow prints a "cannot reach kcp" setup hint only when a step fails due to a genuine connection error. The command docs also point users at the kcp release download and manual start, since embedding kcp in the CLI will bloat the binary.What Type of PR Is This?
/kind cleanup
/kind feature
Related Issue(s)
Fixes #3942
Release Notes