Fix restMapper for core kcp resources - #4298
Merged
Merged
Conversation
kcp-ci-bot
added
release-note-none
Contributor
|
LGTM label has been added. DetailsGit tree hash: 3fcc8b07b02795228d8a0df714179ede230a022e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
neolit123
reviewed
Jul 31, 2026
neolit123
left a comment
neolit123
left a comment
Contributor
There was a problem hiding this comment.
might be worth adding a UT?
kcp-ci-bot
added
size/L
Contributor
Author
What is UT? |
Member
|
Man... that is ugly. I'm thinking if it wouldn't be better to just fix the APIs now. If we copy the v1alpha1 kinds up to v1alpha2 the bug should also be fixed and we don't break kube convention? |
Contributor
|
LGTM label has been added. DetailsGit tree hash: f99a4cdac499e4dadf4ebadf3ac6f5810a852251 |
Contributor
unit tests. i see that you added some in commit 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind bug
We should fix this api incosistency, but as api is in the wild - we need this hack
Related Issue(s)
Fixes #
Release Notes