Forward the caller's identity to virtual workspaces - #4310
Merged
Conversation
The shard proxies virtual resources to the virtual workspace over a connection that authenticates as the shard, so the VW authorized the shard rather than the user. Stamp the request-header identity on the forwarded request instead, clearing any inbound copies first. Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt> On-behalf-of: SAP <mangirdas.judeikis@sap.com>
kcp-ci-bot
added
release-note
Contributor
|
LGTM label has been added. DetailsGit tree hash: 4d57becc897572e2c248340264f387f9f9e1c465 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
github-project-automation
Bot
moved this to Done
in Platform Mesh & Kube Projects - Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shard proxies virtual resources to the virtual workspace over a connection that authenticates as the shard, so the VW authorized the shard rather than the user. Stamp the request-header identity on the forwarded request instead, clearing any inbound copies first.
What Type of PR Is This?
/kind documentation
/kind feature
Related Issue(s)
Fixes #
Release Notes