cli/pkg/base/options.go: don't disable any CLI options - #4313
Conversation
kcp-ci-bot
added
release-note
This allows passing the additional flags: --as --as-group --client-certificate --client-key --cluster --request-timeout The only conflating one might be --cluster in the context of kcp, but there is already a --workspace flag. Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/XS
b684d60 to
d15342c
Compare
There was a problem hiding this comment.
Pull request overview
Enables the full set of clientcmd.RecommendedConfigOverrideFlags that were previously being selectively disabled in cli/pkg/base/options.go, allowing CLI users to pass kubectl-style auth/context flags (notably impersonation and client cert/key) across commands.
Changes:
- Removes the logic that blanked
LongNameon several recommended kubeconfig override flags, re-enabling them in flag binding. - As a result, the following flags become available where
base.Options.BindFlagsis used:--as,--as-group,--client-certificate,--client-key,--cluster,--request-timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This allows passing the additional flags:
--as
--as-group
--client-certificate
--client-key
--cluster
--request-timeout
The only conflating one might be --cluster in the context of kcp, but there is already a --workspace flag.
e.g.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #4312
Release Notes