Skip to content

Make GC cluster-aware - #192

Merged
mjudeikis merged 8 commits into
kcp-dev:kcp-1.35.1from
ntnn:fix-gc
Apr 20, 2026
Merged

Make GC cluster-aware#192
mjudeikis merged 8 commits into
kcp-dev:kcp-1.35.1from
ntnn:fix-gc

Conversation

@ntnn

@ntnn ntnn commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Makes the GC cluster-aware. Companion pr in kcp: kcp-dev/kcp#4044

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

ntnn added 8 commits April 12, 2026 00:04
@ntnn
FIXUP: <carry>: gc & quata patches applied
cd1e84f 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
UPSTREAM: <carry>: Clusterize GC objectReference
1e8b385 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
UPSTREAM: <carry>: Add garbagecollector.WithCluster/.ClusterFrom
4fc637d 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
UPSTREAM: <carry>: Add contextForCluster
8fd85bf 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
UPSTREAM: <carry>: Add cluster annotation to virtual delete events
4153556 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
UPSTREAM: <carry>: Clusterize GC getMetadata
d6bfef5 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
DROP: logicalcluster direct dependency
e849fbc 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@ntnn
UPSTREAM: <carry>: Emit events for the correct cluster
3522d52 
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
@kcp-ci-bot

kcp-ci-bot commented Apr 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ntnn ntnn mentioned this pull request Apr 17, 2026
Merged
mjudeikis
mjudeikis approved these changes Apr 20, 2026
View reviewed changes

@mjudeikis mjudeikis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straight forward

@mjudeikis
mjudeikis merged commit 8d5156c into kcp-dev:kcp-1.35.1 Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntnn @kcp-ci-bot @mjudeikis