common: account for cgroup memory limits - #7
Closed
andyliuliming wants to merge 1 commit into
Closed
Conversation
Memory-heavy tests currently use host-wide values from free(1). In a container, those values can be much larger than the memory available to the current cgroup and can cause avoidable OOM failures. Read the remaining memory from cgroup v1 or v2 when available, keep a small runtime margin, and fall back to the host value for unlimited or unavailable cgroup data. Signed-off-by: Liming Liu <andyliuliming@outlook.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e3c7b420-3283-4416-967b-e6d92a7dd5c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the current cgroup's remaining memory when fstests runs in a memory-limited container instead of relying only on host-wide values from
free(1).The helper supports:
memory.maxandmemory.currentmemory.limit_in_bytesandmemory.usage_in_bytesThis prevents memory-heavy tests such as
generic/551from sizing their workload from memory that is not actually available inside the container.Checks
bash -n common/rcmemory.max=max)