Switch to GitHub actions - #396
Merged
Merged
Conversation
ujovlado
marked this pull request as ready for review
April 8, 2022 19:38
odinuv
approved these changes
Apr 8, 2022
odinuv
left a comment
odinuv
left a comment
Member
There was a problem hiding this comment.
já bych to dal do jednoho jamlu, ale to je o vkusu každého soudruha
Iamfle4ka
pushed a commit
that referenced
this pull request
Aug 4, 2026
#1046 moved 41 pages from developers.keboola.com to /extend/**. Two audit PRs on that repo — keboola/developers-docs#393 and #396, both opened 2026-06-22 and never reviewed — had already found defects on those pages, so the copies that landed here are the *unfixed* ones. Grepping for each fix confirmed every one of them is still present on help. Carried over from #393 and #396: - `ci.validate_configuration(...)` is not a method on CommonInterface; the real one is `validate_configuration_parameters` (python-component interface.py:748). The published example raises AttributeError. - The Python library link pointed at a superseded Bitbucket template (still reachable, last touched 2023) and the PHP one at keboola/php-docker-application, since renamed to keboola/php-component. The Python link now targets the actual example file in the cookiecutter template, since the prose promises "an actual working example" and the template root is not one. - Invalid JSON in four examples: a missing comma before `write_always`, a missing comma after the `schema` member, a missing comma between the `input` and `output` objects, and a trailing comma in the ABS workspace credentials. - `"colummns"`, `write-alwayss.csv`, `my-inpupt.csv` (x4), `accross`, "display events Keboola end-users", "is filter for sensitive values", "does not have an access to". - The input-table manifest's `name` node holds the table name, not the name of the component configuration (input-mapping ManifestCreator.php:23). - The output-mapping page said "Implementing the input mapping requires...". - Two `### Step 4` headings in a row on the debugging page; the second is 5. Nothing in either repo links to that anchor. - `somemyParameter_user_parameter`, where the JSON below it says `myParameter`. Broken links found while checking, not from either PR: - help has no /overview/api/ page — it 404s, that reference lives only on dev docs — yet nine links in the migrated pages pointed at it as a site-relative path. Broken in production right now. Repointed at developers.keboola.com. - The anchor was dead too: the heading is "## Stacks and Endpoints", so `#regions-and-endpoints` resolved nowhere. Three native help pages carried the same dead anchor, which leaves none in the repo. - Four links to `/extend/component/running/#preparing-the-data-folder`, whose heading is "## Preparing Data folder". Repointed at the slug that exists, rather than renaming the heading, which would break the links #406 repoints. - `debugging/#step-2--build-the-image`, whose heading is "### Step 2 -- Build Image". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Po mergi a uspesnom deploymente by som zmazal
mastera prenastavil rules.