Modernize installation a bit #73
Merged
Merged
Conversation
pivnicek
approved these changes
May 21, 2023
| RUN python setup.py install | ||
| RUN python -m pip install --upgrade pip | ||
| RUN pip install --no-cache-dir flake8 | ||
| RUN pip install --no-cache-dir . |
| ```bash | ||
| $ git clone https://github.com/keboola/sapi-python-client.git && cd sapi-python-client | ||
| $ python setup.py install | ||
| pip install git+https://github.com/keboola/sapi-python-client.git |
Contributor
There was a problem hiding this comment.
just btw, it can now be installed with pip install kbcstorage https://pypi.org/project/kbcstorage/
|
|
||
| ## Client Class Usage | ||
| ``` | ||
| ```python |
Contributor
There was a problem hiding this comment.
just curious, what does this do?
Member
Author
There was a problem hiding this comment.
uses the python highligher, for simple code it does not matter, as the generic one does well, but sometimes it does some weirdness
Comment on lines
+75
to
+85
| Note that if you submit a PR from your own forked repository, the automated functional tests will fail. | ||
| This is expected for security reasons, please do send the PR anyway. | ||
| Either run the tests locally (set `KBC_TEST_TOKEN` (your token to test project) and | ||
| `KBC_TEST_API_URL` (https://connection.keboola.com) variables) or ask for access. In case, you need a | ||
| project for local testing, feel free to [ask for one](https://developers.keboola.com/#development-project). |
remove setup.py update & polish readme and running instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pyproject.toml instead of setup.py and related stuff.
Part of https://keboola.atlassian.net/browse/AIS-35
Depends on #72