[🐛 Bug]: PUSHER_USE_SSL is incorrectly parsed

[paul-serdiuk]

In keep/api/core/dependencies.py, and in the docs, the env PUSHER_USE_SSL is expected to be a boolean, but Docker Compose doesn't support booleans. Setting PUSHER_USE_SSL: false will therefore pass it on as a string and evaluate to True.

The fix should look something like this:

pusher_use_ssl = os.environ.get("PUSHER_USE_SSL", "false").lower() in (
    "1",
    "true",
    "yes",
    "on",
)

pusher = Pusher(
    host=pusher_host,
    port=int(os.environ["PUSHER_PORT"]) if os.environ.get("PUSHER_PORT") else None,
    app_id=pusher_app_id,
    key=pusher_app_key,
    secret=pusher_app_secret,
    ssl=pusher_use_ssl,
    cluster=os.environ.get("PUSHER_CLUSTER"),
)

This bug might be affecting other similar cases.

[SueJianjian]

I can take this one.

The scope looks small and well-defined, so I'd keep it to:

1. reproducing the current PUSHER_USE_SSL parsing behavior
2. fixing the env var normalization so string values like false do not evaluate truthy
3. adding a regression test for the boolean parsing path
4. opening a scoped PR with validation notes

Before I start, can you confirm:

• whether this issue has an attached payout/bounty path
• whether anyone is already assigned or actively working on it

If it's unassigned, I can start from the repro and send a narrow fix PR.

[cschanhniem]

I traced the exact source to keep/api/core/dependencies.py:get_pusher_client(). Two distinct bugs in one line:

ssl=False if os.environ.get("PUSHER_USE_SSL", False) is False else True,

Bug 1: is False is identity comparison, never matches strings. Python os.environ values are always str, so "false" is False is always False.

Bug 2: False as default has no effect — when the env var is unset, os.environ.get("PUSHER_USE_SSL", False) returns False, then False is False is True, so ssl = False (correct by accident). But the str vs bool type mismatch is fragile and the semantics are inverted from what a reader expects.

Fix: use the same pattern PUSHER_DISABLED already uses two lines above:

pusher_use_ssl = os.environ.get("PUSHER_USE_SSL", "false").lower() in ("1", "true", "yes", "on")
pusher = Pusher(
    host=pusher_host,
    port=int(os.environ["PUSHER_PORT"]) if os.environ.get("PUSHER_PORT") else None,
    app_id=pusher_app_id,
    key=pusher_app_key,
    secret=pusher_app_secret,
    ssl=pusher_use_ssl,
    cluster=os.environ.get("PUSHER_CLUSTER"),
)

The PUSHER_DISABLED check already uses the correct == "true" string comparison — same fix applies to PUSHER_USE_SSL.

I can open a PR with this fix if it hasn't been picked up yet.