fix: parse PUSHER_USE_SSL and PUSHER_DISABLED env booleans correctly#6583
Open
SueJianjian wants to merge 3 commits into
Open
fix: parse PUSHER_USE_SSL and PUSHER_DISABLED env booleans correctly#6583SueJianjian wants to merge 3 commits into
SueJianjian wants to merge 3 commits into
Conversation
shahargl
requested changes
Jun 16, 2026
shahargl
left a comment
Member
There was a problem hiding this comment.
I think this is a bit over engineering, you can use Config class for that
Author
|
Updated this to use the existing Config bool parsing instead of a custom helper, and switched the tests to cover get_pusher_client() behavior directly. Could you take another look when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6582
Testing