Skip to content

feat(incident): activity tab#2185

Merged
talboren merged 13 commits into
mainfrom
2128--feature-incident-activity
Oct 21, 2024
Merged

feat(incident): activity tab#2185
talboren merged 13 commits into
mainfrom
2128--feature-incident-activity

Conversation

@talboren

@talboren talboren commented Oct 13, 2024

Copy link
Copy Markdown
Member
CleanShot.2024-10-13.at.15.22.04.mp4

@talboren talboren linked an issue Oct 13, 2024 that may be closed by this pull request
@vercel

vercel Bot commented Oct 13, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 1:01pm

@shahargl

Copy link
Copy Markdown
Member

👏

@talboren

Copy link
Copy Markdown
Member Author

I can't seem to fix the bug with the icons that gets messy after a few new items, I've created this to see if the maintainer could maybe help us out: prabhuignoto/react-chrono#509

@talboren
talboren force-pushed the 2128--feature-incident-activity branch from a85e06d to e4ad76e Compare October 21, 2024 07:16

@Kiryous Kiryous left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a few comments, otherwise it's good to go!

Comment thread keep-ui/app/incidents/[id]/incident-activity.tsx Outdated
Comment thread keep-ui/app/incidents/[id]/incident-activity.tsx Outdated
Comment thread keep-ui/app/incidents/[id]/incident-activity.tsx
Comment thread keep-ui/app/incidents/[id]/incident-activity.tsx
Co-authored-by: Kirill Chernakov <yakiryous@gmail.com>
Signed-off-by: Tal <talboren2@gmail.com>
@talboren

Copy link
Copy Markdown
Member Author

@Kiryous applied your suggestions! lmk if you're good with it and let's push it in :)

@Kiryous Kiryous left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren
talboren merged commit 7bf3c83 into main Oct 21, 2024
@talboren
talboren deleted the 2128--feature-incident-activity branch October 21, 2024 13:20
wsimon1982 pushed a commit to wsimon1982/keep that referenced this pull request May 12, 2026
Signed-off-by: Tal <tal@keephq.dev>
Signed-off-by: Tal <talboren2@gmail.com>
Co-authored-by: Shahar Glazner <shaharglazner@gmail.com>
Co-authored-by: Kirill Chernakov <yakiryous@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Incident Activity

3 participants