fix: register Osmosis and Binance in transport typeRegistry#33
Merged
BitHighlander merged 1 commit intomasterfrom Mar 25, 2026
Merged
fix: register Osmosis and Binance in transport typeRegistry#33BitHighlander merged 1 commit intomasterfrom
BitHighlander merged 1 commit intomasterfrom
Conversation
…stry
The transport's fromMessageBuffer() looks up response message types in
messageTypeRegistry to deserialize device responses. Osmosis and Binance
proto constructors were never registered, so the device's valid
OsmosisAddress (1101) / BinanceAddress responses were silently converted
to FAILURE("Unknown message type received") at the hdwallet layer.
The firmware handles these chains correctly — the error was entirely
client-side deserialization failure.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BitHighlander
added a commit
that referenced
this pull request
Mar 25, 2026
…Registry
Ethereum response types (EthereumAddress=57, EthereumTxRequest=59,
EthereumMessageSignature=110, EthereumTypedDataSignature=113) were
never registered in the transport type registry. The device sends
valid responses but the transport can't deserialize them, fabricating
FAILURE("Unknown message type received") instead.
ETH getAddress appeared to work because EvmAddressManager silently
catches the error and falls back to cached addresses. But ETH signing
(signTx, signMessage, signTypedData) has no fallback and is broken.
Also registers Tendermint (1000-1011) for completeness — currently
unused but prevents future gaps.
Same bug class as Osmosis/Binance (fixed in #33).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OsmosisMessagesandBinanceMessagesto the transport type registryFAILURE("Unknown message type received")even though the firmware handles these chains correctlyRoot cause
typeRegistry.tsbuildsmessageTypeRegistryfromAllMessages, which concatenates all proto modules. Osmosis and Binance proto modules were imported in their respective chain files (osmosis.ts,binance.ts) for sending messages, but never added toAllMessages— so response types couldn't be deserialized.Cosmos, THORChain, Mayachain, Ripple, EOS, Nano, Zcash were all registered. Solana/TON/TRON self-register via side-effect functions. Osmosis and Binance were the gap.
Test plan
osmosisGetAddress()returns address instead of FAILUREbinanceGetAddress()returns address instead of FAILURE