fix: register Ethereum and Tendermint in transport typeRegistry#34
Merged
BitHighlander merged 1 commit intomasterfrom Mar 25, 2026
Merged
fix: register Ethereum and Tendermint in transport typeRegistry#34BitHighlander merged 1 commit intomasterfrom
BitHighlander merged 1 commit intomasterfrom
Conversation
…Registry
Ethereum response types (EthereumAddress=57, EthereumTxRequest=59,
EthereumMessageSignature=110, EthereumTypedDataSignature=113) were
never registered in the transport type registry. The device sends
valid responses but the transport can't deserialize them, fabricating
FAILURE("Unknown message type received") instead.
ETH getAddress appeared to work because EvmAddressManager silently
catches the error and falls back to cached addresses. But ETH signing
(signTx, signMessage, signTypedData) has no fallback and is broken.
Also registers Tendermint (1000-1011) for completeness — currently
unused but prevents future gaps.
Same bug class as Osmosis/Binance (fixed in #33).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EthereumMessagesandTendermintMessagesto the transport type registrysignTx,signMessage,signTypedData) which silently fail because the transport can't deserialize device responsesRoot cause
Same class of bug as #33 (Osmosis/Binance). The Ethereum proto module (
messages-ethereum_pb) was imported inethereum.tsfor sending messages but never added toAllMessagesintypeRegistry.ts. Device responses (EthereumAddress=57,EthereumTxRequest=59,EthereumMessageSignature=110,EthereumTypedDataSignature=113) couldn't be deserialized — the transport fabricatesFAILURE("Unknown message type received").Why ETH appeared to work
EvmAddressManager.initialize()wrapsethGetAddress()intry { } catch { continue }(evm-addresses.ts:170), silently swallowing the deserialization failure. Addresses load from SQLite cache instead. But signing has no such fallback —ethSignTx()fails outright when the device responds withEthereumTxRequest(type 59).Verified
Built and tested the compiled registry — all response types now resolve:
Coverage after this PR + #33
All 14 proto modules are now registered:
AllMessages(always was)AllMessages(#33)AllMessages(always was)AllMessages(always was)AllMessages(this PR)AllMessages(always was)AllMessages(always was)AllMessages(#33)AllMessages(always was)AllMessages(this PR)AllMessages(always was)AllMessages(always was)solana.ts)tron.ts)ton.ts)Test plan
ethGetAddress()returns address (not FAILURE)ethSignTx()completes signing flow (EthereumTxRequest deserialized)ethSignMessage()returns signatureethSignTypedData()returns signature