fix(zcash): forward Ironwood signing metadata - #58
Draft
BitHighlander wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Restore the established @bithighlander/device-protocol npm flow at exact version 7.17.0 and remove the temporary Git dependency source-generation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ZcashSignPCZT@bithighlander/device-protocol@7.17.0package through the established@keepkey/device-protocolnpm aliasWhy
Vault was still loading generated v5/Orchard client code. The sidecar could build a v6 Ironwood transaction, but hdwallet omitted
shielded_poolandironwood_digest, so the device signed the old request shape and the resulting transaction was rejected by NU6.3 consensus.The BitHighlander package carries the complete staged protocol bindings. The
@keepkey/device-protocolpackage remains reserved for publication after the protocol changes merge to upstream master.Validation
yarn buildyarn lintyarn test --runInBand --coverage=false— 112/112 passing@bithighlander/device-protocol@7.17.0d884b698, branch37a5165b, Ironwood pool enum, digest field 20, and compact real-spend signature countsac7f54975154f9c242a49fa151bcbc2badbb7591a8877ff9f75dbba305fdf2fd, mined in block3430876Draft pending final release-train review.