fix(windows): installer.iss comment broke Inno section parsing#233
Merged
Conversation
…er.iss comment
The per-user-install warning comment in InitializeSetup wrapped onto a line
beginning (after indentation) with "[Code]". Inno Setup splits sections by
scanning for lines that start with "[" before it parses Pascal { } comments,
so it read "[Code] MsgBox, ..." as a malformed section header and aborted with
"Error on line 96 ... Invalid section tag", breaking the Windows installer
build (ISCC exit 2).
Reword the comment so no line starts with "[". Comment-only change; no
installer behavior change.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The manual Windows installer build (
scripts/build-windows-production.ps1→ ISCC onscripts/installer.iss) fails to compile:Line 96 is part of a Pascal
{ }comment inside the[Code]section (the per-user-install stale-install warning). The line begins, after indentation, with[Code]:Inno Setup determines section boundaries by scanning for lines that start with
[before Pascal{ }comments are parsed, so it treats[Code] MsgBox, ...as a malformed section header and aborts (ISCC exit 2). This only affects the manual Windows/Inno build; CI's macOS/Linux builds never touchinstaller.iss.Fix
Reword the comment so no line starts with
[. Comment-only change — no installer behavior change.Verification
Built and signed
KeepKey-Vault-1.4.3-win-x64-setup.exefrom this change: Inno compile succeeds, installer Authenticode is Valid + RFC3161 timestamped.🤖 Generated with Claude Code