Revert swap-into-vault work (#254–#257) — wrong project#259
Merged
Conversation
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #254, #255, #256, #257, which were merged to develop by mistake.
Those PRs rebuilt swap inside keepkey-vault (re-housed the swap modal as a side panel, rebranded the ShapeShift nav tab to KeepKey, added a front-page Send/Receive/Swap row, in-code flag, version bump). That was the wrong project: vault already has working swaps, and the actual epic is adding swaps into keepkey-client's side panel. These changes altered vault's existing swap UX and shouldn't be on develop.
This reverts all four merges (in reverse order). Verified: the resulting tree is identical to the pre-#254 state (
b61ca9b1) — emptygit diff. Vault returns to: ShapeShift nav tab, original modal swap, version 1.4.4;flags.tsandSendReceivePicker.tsxremoved.