fix(rc24): add Taproot and entropy host acceptance - #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release blocker addressed
The exact RC23 candidate returned a valid 64-byte Schnorr signature for a P2TR transaction without showing any physical transaction confirmation. RC23 is blocked. The RC24 hardware phase in this PR requires exact firmware-hash matching, recipient/fee attestation, cancellation rejection, and never broadcasts its synthetic transactions.
This host PR must be tested with the fail-closed firmware repair in keepkey-firmware #330, the BIP86 change-output guard in #333, and repaired entropy #332. It does not make the firmware release-ready by itself.
Verification
Scope
Taproot and entropy only. x402, ClearSign, and unrelated stacked work are intentionally excluded.