Skip to content

release: allow the Umami tracker in CSP - #179

Merged
manager merged 1 commit into
mainfrom
dev
Aug 12, 2026
Merged

release: allow the Umami tracker in CSP#179
manager merged 1 commit into
mainfrom
dev

Conversation

@manager

@manager manager commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Ships the CSP fix from #178 to production, so the tracker shipped in #176 can actually load and send events.

Verified on staging: the rebuilt container is healthy, the site answers 200, and the served CSP header now lists analytics.administration.ae in both script-src and connect-src.

🤖 Generated with Claude Code

The Umami script tag shipped in #176 is blocked by our own CSP: neither
script-src nor connect-src allows analytics.administration.ae, so browsers
refuse to load the tracker and to send events. Adds the host to both.
@manager
manager merged commit 49611ab into main Aug 12, 2026
1 check passed
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Claude finished @manager's task in 44s —— View job


Reviewing PR #179

Summary

This is a release PR (devmain) that ships the CSP fix from #178: it adds https://analytics.administration.ae to both script-src (next.config.js:37) and connect-src (next.config.js:48) so the self-hosted Umami tracker introduced in #176 can load its script and send events.

Assessment: LGTM. The change is minimal, config-only, and matches the existing array-based CSP pattern in next.config.js (each source is a commented string entry, joined via filter(Boolean).join(' ')). No React/TS/styling surface is touched, so none of the usual review dimensions (hooks, hydration, a11y, SCSS) apply here.

A few things worth noting, not blockers:

  • Both entries are commented (// Self-hosted Umami tracker. / // Self-hosted Umami event collection.), consistent with the file's existing style — good.
  • analytics.administration.ae is distinct from the already-allowed metrics.administration.ae in connect-src (next.config.js:46) — worth double-checking these are in fact two separate legitimate endpoints and not a typo/duplicate, but the PR description confirms this was verified live on staging (CSP header inspection, 200 response).
  • Scope is correctly narrow: no wildcard or overly broad CSP directive was introduced.

Since this PR only promotes an already-reviewed fix (#178) to main, and staging verification is documented in the PR description, there's nothing further to flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant