refactor: extract runOnce to scripts/lib/subprocess.ts with cwd support#157
Merged
Conversation
Move runOnce from scripts/triage/subprocess.ts to scripts/lib/subprocess.ts so it can be shared between triage and review scripts. Add a cwd option to RunOnceOpts and change the signature from positional timeoutMs to an opts object. Update callers and tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
Owner
Author
|
[Baton Reviewer] Managed by Baton; do not edit the marker line manually. PR #157 is ready for human review. No actionable defects found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runOncefromscripts/triage/subprocess.tstoscripts/lib/subprocess.tsso it can be shared between triage and review scriptstimeoutMstoopts?: RunOnceOptswhereRunOnceOpts = { timeoutMs?: number; cwd?: string }cwdsupport inspawn()optionsclaude-eval.ts,copilot-eval.ts) and tests accordinglyCloses #150
Test plan
npm run typecheckpassesnpm run lintpassesnpm run testpasses (all 337 tests, including triage-subprocess and triage-evaluator)🤖 Generated with Claude Code