Hiper: Fix pages loading, add back Cleaning title while browsing & optional to cleaning in details screen only#17443
Closed
cuong-tran wants to merge 5 commits into
Closed
Hiper: Fix pages loading, add back Cleaning title while browsing & optional to cleaning in details screen only#17443cuong-tran wants to merge 5 commits into
cuong-tran wants to merge 5 commits into
Conversation
Contributor
|
There are three issues about this extension. Can you mention with "Closes" those that will be fixed with your pr? |
Contributor
Author
This PR fixes none of those 3 issues. |
AwkwardPeak7
reviewed
Jul 9, 2026
AwkwardPeak7
left a comment
Contributor
There was a problem hiding this comment.
the extension is broken so I don't think pushing this preference is worth it; + do we need such preference?
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #17531
Reason: This source often has 2 versions of a same manhwa, the normal one and the "(Uncensored)" one, showing together. For the purpose of normalizing title and duplicate matching, the pref to
Clean titleneed to be turned on. But when it's turned on, both versions appear to have the same name while browsing and are indistinguishable.This PR adds a pref that won't apply cleaning title while browsing. So that:
Checklist:
versionCodevalue inbuild.gradle.ktsbaseVersionCodeinbuild.gradle.kts(if updated multisrc theme code)contentWarningconfiguration inbuild.gradle.ktsappropriatelyidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension