Skip to content

Hiper: Fix pages loading, add back Cleaning title while browsing & optional to cleaning in details screen only#17443

Closed
cuong-tran wants to merge 5 commits into
keiyoushi:mainfrom
cuong-tran:hiperdex
Closed

Hiper: Fix pages loading, add back Cleaning title while browsing & optional to cleaning in details screen only#17443
cuong-tran wants to merge 5 commits into
keiyoushi:mainfrom
cuong-tran:hiperdex

Conversation

@cuong-tran

@cuong-tran cuong-tran commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Close: #17531

Reason: This source often has 2 versions of a same manhwa, the normal one and the "(Uncensored)" one, showing together. For the purpose of normalizing title and duplicate matching, the pref to Clean title need to be turned on. But when it's turned on, both versions appear to have the same name while browsing and are indistinguishable.

This PR adds a pref that won't apply cleaning title while browsing. So that:

  • When browsing/searching, the 2 versions are distinguishable.
  • When opening the detail screen, the title is still cleaned so I can add it to library normalized.

Checklist:

  • Updated versionCode value in build.gradle.kts
  • Updated baseVersionCode in build.gradle.kts (if updated multisrc theme code)
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Set the contentWarning configuration in build.gradle.kts appropriately
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop

@Exinaus

Exinaus commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

There are three issues about this extension. Can you mention with "Closes" those that will be fixed with your pr?

@cuong-tran

Copy link
Copy Markdown
Contributor Author

There are three issues about this extension. Can you mention with "Closes" those that will be fixed with your pr?

This PR fixes none of those 3 issues.

@AwkwardPeak7 AwkwardPeak7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the extension is broken so I don't think pushing this preference is worth it; + do we need such preference?

@cuong-tran cuong-tran marked this pull request as draft July 9, 2026 05:50
@cuong-tran cuong-tran changed the title Hiperdex: Option to not clean title during browsing/search Hiper: Fix pages loading, add back Cleaning title while browsing & optional to cleaning in details screen only Jul 11, 2026
@cuong-tran cuong-tran marked this pull request as ready for review July 11, 2026 11:18
@keiyoushi keiyoushi locked and limited conversation to collaborators Jul 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiper (Hiperdex, HipercooL): No pages found error

3 participants