Skip to content

Minor features#3

Merged
kelleyblackmore merged 5 commits into
mainfrom
env-updates-gen-pass
Nov 12, 2025
Merged

Minor features#3
kelleyblackmore merged 5 commits into
mainfrom
env-updates-gen-pass

Conversation

@kelleyblackmore
Copy link
Copy Markdown
Owner

added password gen, env updater, included in dev vault instance, .devcontainer

Copilot AI review requested due to automatic review settings November 12, 2025 08:29
@kelleyblackmore
Copy link
Copy Markdown
Owner Author

Also need to go back and fix the deadcode

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/env_updater.rs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds several minor features to enhance development workflow and local environment management for the secret rotation tool. The changes introduce password generation capabilities, environment variable synchronization with Vault, and improved development tooling.

Key Changes:

  • New GenPassword and UpdateEnv commands for managing passwords and syncing them to local shell configuration files
  • Enhanced Vault client to gracefully handle empty paths (404 responses)
  • Comprehensive Makefile with Vault development targets and Docker integration

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/vault.rs Added 404 handling for empty secret paths during list operations
src/main.rs Implemented UpdateEnv and GenPassword commands for local environment management
src/env_updater.rs New module for updating environment variables in shell config files (.bashrc, .zshrc, etc.)
examples/rotator-config.toml Added minimal example configuration for quick setup
examples/config.toml Updated default token to "root" for local development with Vault Docker
Makefile Comprehensive build, test, and Vault development targets for improved developer experience
.devcontainer/install-vault.sh Script to install HashiCorp Vault in devcontainer
.devcontainer/devcontainer.json Configured Rust and Vault features for VS Code devcontainer support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
Comment thread Makefile
Comment thread src/env_updater.rs
Comment thread src/env_updater.rs
Comment thread Makefile
Comment thread src/env_updater.rs
Comment thread src/env_updater.rs Outdated
Comment thread src/env_updater.rs
Comment thread Makefile Outdated
Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 12, 2025

@kelleyblackmore I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you.

kelleyblackmore and others added 3 commits November 12, 2025 01:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 12, 2025

@kelleyblackmore I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

@kelleyblackmore kelleyblackmore merged commit 4967e09 into main Nov 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants