Fix shell escaping vulnerability in env_updater#6
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Merged
Co-authored-by: kelleyblackmore <16111250+kelleyblackmore@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from review on minor features PR
Fix shell escaping vulnerability in env_updater
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses security issue where environment variable values were written to shell config files without escaping, enabling command injection via special characters.
Changes
escape_shell_value()- Escapes\,",$,`, and\nbefore writing to shell filesupdate_in_file()andappend_to_file()- Both now escape values before insertionExample
Before:
After:
Additional Fix
Restored proper
skip_next_commentlogic inremove_from_file()that was broken in previous commit.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.