feat(Melon): Implement Melon provider - #234
Conversation
|
Still plan to do some fine-tuning on the provider implementation and fix the ToDo I left there, but I think it is mostly ready to review already. |
kellnerd
left a comment
kellnerd
left a comment
There was a problem hiding this comment.
Thank you for giving this a shot. Sorry that it took quite a while till I came back to reviewing it, I needed a short break after your last PR and then it got too hot and my motivation was melting like ice in the sun.
Without having tried the provider so far, here is some initial feedback.
ec92daa to
6f06a09
Compare
kellnerd
left a comment
kellnerd
left a comment
There was a problem hiding this comment.
Looking good, you can now rearrange the commits while you do the last minor changes.
Especially the test data changes should be squashed to remove them from history.
Melon is a South Korean digital streaming service. This provider uses the mobile app's API, which is publicly accessible without authentication. The API returns album metadata and track listings via separate endpoints. The brand color and icon have been taken from the website. To implement this change, I used the help of an AI tool (namely Claude Code using the Sonnet 4.6 model), which created the Melon API types from HTTP responses captured with curl using the endpoints described in kellnerd#203, and wrote the initial provider implementation (using the previous Bugs! provider as a reference). Regardless, all code changes have been personally reviewed by me, and I take full responsibility for them. I also selected and wrote the test cases myself. Assisted-by: Claude:claude-sonnet-4.6 Assisted-by: Claude:claude-fable-5
e3e2065 to
7ff8df8
Compare
|
Done. I applied your suggestions as well as a few minor fixes from another review pass with Claude (Fable 5, added to the commit message). I also moved the CSS formatting change to a separate commit, and added support for mobile URLs and live albums. |
3 participants
Melon is a South Korean digital streaming service. This provider uses the mobile app's API, which is publicly accessible without authentication. The API returns album metadata and track listings via separate endpoints. The brand color and icon have been taken from the website.
To implement this change, I used the help of an AI tool (namely Claude Code using the Sonnet 4.6 model), which created the Melon API types from HTTP responses caputured with curl using the endpoints described in #203, and wrote the initial provider implementation (using the previous Bugs! provider as a reference). Regardless, all code changes have been personally reviewed by me, and I take full responsibility for them. I also selected and wrote the test cases myself.
Assisted-by: Claude:claude-sonnet-4.6
Closes #203.